Removal of whitespace in changelog and readme

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Removal of whitespace in changelog and readme

Mark Rotteveel-2
I just came across this commit by Adriano:

https://github.com/FirebirdSQL/firebird/commit/c2584cf84be78f4aa157f003445dd17c8bc52c3f

It removes a number of double-whitespaces in the CHANGELOG.md and
README.md. Double whitespace at the end of a line has meaning in
markdown: it introduces an explicit linebreak, otherwise the linebreak
is just non-linebreak whitespace when rendered.

In my opinion this commit breaks the formatting and should be reverted.

Compare:

Before this commit:
https://github.com/FirebirdSQL/firebird/blob/57351a030ce72e5772e696f23ae174ee2c21bf69/CHANGELOG.md

after this commit:
https://github.com/FirebirdSQL/firebird/blob/c2584cf84be78f4aa157f003445dd17c8bc52c3f/CHANGELOG.md
--
Mark Rotteveel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Removal of whitespace in changelog and readme

Dmitry Yemanov-3
17.07.2017 10:48, Mark Rotteveel wrote:

> I just came across this commit by Adriano:
>
> https://github.com/FirebirdSQL/firebird/commit/c2584cf84be78f4aa157f003445dd17c8bc52c3f 
>
>
> It removes a number of double-whitespaces in the CHANGELOG.md and
> README.md. Double whitespace at the end of a line has meaning in
> markdown: it introduces an explicit linebreak, otherwise the linebreak
> is just non-linebreak whitespace when rendered.
>
> In my opinion this commit breaks the formatting and should be reverted.

Agreed. I will let Adriano to revert this himself.


Dmitry

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Removal of whitespace in changelog and readme

Adriano dos Santos Fernandes-3
In reply to this post by Mark Rotteveel-2
On 17/07/2017 04:48, Mark Rotteveel wrote:
> Double whitespace at the end of a line has meaning in markdown: it
> introduces an explicit linebreak, otherwise the linebreak is just
> non-linebreak whitespace when rendered.

I was not aware about this. :(

These spaces were causing troubles to me when I edited the files, so I
put in my review script to trim them from .md files, like I was doing
for .h, .cpp, etc.

I'll revert it, thanks.


Adriano


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Loading...